Remove redundant memory monitor settings reload call#37
Merged
Conversation
Remove redundant LoadMemoryMonitorSettings() call in ApplicationContext.LoadSettings(). The CustomScheduler constructor already loads these settings, so the call in LoadSettings() was causing a third unnecessary load on every startup. The method remains callable from MainForm.RefreshSettings() for when users actually change options. https://claude.ai/code/session_019Awk1AL8nMfrcMU753RxCd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed a redundant call to
LoadMemoryMonitorSettings()from the settings loading workflow in ApplicationContext.Key Changes
_customScheduler.LoadMemoryMonitorSettings()call from the settings initialization sequenceImplementation Details
The removed code was reloading memory monitor and daily restart settings on the scheduler during the settings load operation. This appears to have been redundant, possibly being handled elsewhere in the initialization flow or no longer necessary for the current implementation.