Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/core/plugins/err/error-transformers/hook.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import reduce from "lodash/reduce"
import * as NotOfType from "./transformers/not-of-type"
import * as ParameterOneOf from "./transformers/parameter-oneof"
import * as ExampleMutuallyExclusive from "./transformers/example-mutually-exclusive"

const errorTransformers = [
NotOfType,
ParameterOneOf
ParameterOneOf,
ExampleMutuallyExclusive
]

export default function transformErrors (errors) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
export function transform(errors) {
// Filter out false-positive "mutually exclusive" errors for ExampleElement
// that occur when path-level $ref is used with examples containing externalValue.
// This is a known issue in the upstream apidom-reference library where
// the resolver incorrectly reports value and externalValue as mutually exclusive
// after resolving a path-level $ref.
// See: https://github.com/swagger-api/swagger-ui/issues/10418
return errors.filter((err) => {
if (err.get("source") !== "resolver") {
return true
}
const message = err.get("message") || ""
return (
message.indexOf(
"ExampleElement value and externalValue fields are mutually exclusive"
) === -1
)
})
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
import { Map, List } from "immutable"
import { transform } from "core/plugins/err/error-transformers/transformers/example-mutually-exclusive"

describe("err plugin - transformers - example mutually exclusive", () => {

it("should filter out false-positive ExampleElement mutually exclusive resolver errors", () => {
let ori = List([
Map({
path: "post.responses.200.content.application/json.examples.testExample.externalValue",
message: "Could not resolve reference: ExampleElement value and externalValue fields are mutually exclusive.",
source: "resolver",
level: "error",
type: "thrown"
})
])

let res = transform(ori)

expect(res.size).toEqual(0)
})

it("should not filter out non-resolver errors with the same message", () => {
let ori = List([
Map({
path: "some.path",
message: "ExampleElement value and externalValue fields are mutually exclusive.",
source: "parser",
level: "error",
type: "thrown"
})
])

let res = transform(ori)

expect(res.size).toEqual(1)
})

it("should not filter out other resolver errors", () => {
let ori = List([
Map({
path: "some.path",
message: "Could not resolve reference: some other error",
source: "resolver",
level: "error",
type: "thrown"
})
])

let res = transform(ori)

expect(res.size).toEqual(1)
})

it("should keep unrelated errors while filtering the mutually exclusive error", () => {
let ori = List([
Map({
path: "info.version",
message: "is not of a type(s) string",
source: "structural",
level: "error"
}),
Map({
path: "post.responses.200.content.application/json.examples.testExample.externalValue",
message: "Could not resolve reference: ExampleElement value and externalValue fields are mutually exclusive.",
source: "resolver",
level: "error",
type: "thrown"
}),
Map({
path: "paths./test",
message: "Could not resolve reference: Network error",
source: "resolver",
level: "error",
type: "thrown"
})
])

let res = transform(ori)

expect(res.size).toEqual(2)
expect(res.get(0).get("message")).toEqual("is not of a type(s) string")
expect(res.get(1).get("message")).toEqual("Could not resolve reference: Network error")
})

})