Refactor boundary detection to avoid cells on both sides of the shared edge are flagged as "boundary cells"#3
Open
crazyzlj wants to merge 1 commit intoswat-model:masterfrom
Conversation
…e bouuundary line with HRUs are all defined as "boundary" Updated boundary detection logic by creating an internal boundary and adjusting spatial joins to identify true boundary cells.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, as shown in the figure below, if an HRU boundary aligns perfectly with a grid edge, the cells on both sides are flagged as 'boundary cells.' Actually, only the cell to the right (in this instance) should be classified as such. So, I recommend creating an inner boundary of the HRUs using a very small buffer (e.g., 1e-5, since the data must be with a projected coordinate system) first, and then perform the spatial join operation.