Closed
Conversation
marcprux
commented
Mar 12, 2026
.github/workflows/pull_request.yml
Outdated
| enable_windows_checks: true | ||
| windows_swift_versions: '["nightly-main"]' | ||
| windows_pre_build_command: | | ||
| winget install Microsoft.OpenJDK.21 |
Author
There was a problem hiding this comment.
This is failing silently:
winget : The term 'winget' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling of the name, or
if a path was included, verify that the path is correct and try again.
At C:\test-script\run.ps1:20 char:1
+ winget install Microsoft.OpenJDK.21
@compnerd, do you happen to know the best way to install something on the Windows image run by the github-workflows? I can't find any examples of any other Swift packages doing this.
There was a problem hiding this comment.
My preference is manually. Download the MSI and install that via msiexec. A good example is the Swift installation itself. (https://github.com/compnerd/gha-setup-swift)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install Java on the Windows CI in order to launch and run JVM tests.