Adopt changed SourceKitLSPAPI to return build settings for build plugins#2446
Open
ahoppen wants to merge 2 commits intoswiftlang:mainfrom
Open
Adopt changed SourceKitLSPAPI to return build settings for build plugins#2446ahoppen wants to merge 2 commits intoswiftlang:mainfrom
ahoppen wants to merge 2 commits intoswiftlang:mainfrom
Conversation
Member
Author
|
swiftlang/swift-package-manager#9583 @swift-ci Please test |
Member
Author
|
swiftlang/swift-package-manager#9583 @swift-ci Please test |
hamishknight
approved these changes
Mar 16, 2026
Member
Author
|
swiftlang/swift-package-manager#9583 @swift-ci Please test Windows |
… in SwiftPMBuildServer To stage in swiftlang/swift-package-manager#9583 because SwiftPM doesn’t support cross-PR testing.
ahoppen
added a commit
to ahoppen/swift-package-manager
that referenced
this pull request
Apr 4, 2026
…ion` To stage in swiftlang#9583. Steps: 1. Merge this PR 2. Change SourceKit-LSP to pass a `pluginConfiguration` 3. Merge swiftlang#9583 4. Merge swiftlang/sourcekit-lsp#2446 for a test in SourceKit-LSP
This was referenced Apr 4, 2026
ahoppen
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 12, 2026
The computation of compiler arguments for package plugins was plain out broken and didn’t even include the search path to `lib/swift/pm/PluginAPI`. Call into the same logic with which we compute the build settings during building from `SourceKitLSPAPI`. Tested as part of swiftlang/sourcekit-lsp#2446. Fixes swiftlang/sourcekit-lsp#2115
Member
Author
|
@swift-ci Please test |
Teemperor
pushed a commit
to Teemperor/swift-mono
that referenced
this pull request
Apr 12, 2026
=== indexstore-db ======================================== Merge pull request #285 from ahoppen/index-dump Create an executable to dump index or record files === swiftpm ============================================== Compute correct compiler arguments for build plugins (#9583) The computation of compiler arguments for package plugins was plain out broken and didn’t even include the search path to `lib/swift/pm/PluginAPI`. Call into the same logic with which we compute the build settings during building from `SourceKitLSPAPI`. Tested as part of swiftlang/sourcekit-lsp#2446. Fixes swiftlang/sourcekit-lsp#2115
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/swift-package-manager#9583.
Fixes #2115