Add Remove unused parameter code action#2548
Closed
william-laverty wants to merge 1 commit intoswiftlang:mainfrom
Closed
Add Remove unused parameter code action#2548william-laverty wants to merge 1 commit intoswiftlang:mainfrom
william-laverty wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Add a syntactic code action that removes a function parameter that is not referenced in the function body and updates call sites within the same file. The action is offered when the cursor is on a parameter in a function declaration and that parameter's local name is not referenced anywhere in the function body. Call site detection matches function calls by name and argument label at the expected position, removing the corresponding argument. Resolves #2513
Member
|
Same here, there’s already a PR that addresses this: #2530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a syntactic code action that removes a function parameter not referenced in the function body and updates call sites within the same file.
Changes
RemoveUnusedParametercode action inSources/SwiftLanguageService/CodeActions/allSyntaxCodeActionsBehavior
The action is offered when the cursor is on a parameter in a function declaration where:
_Call site updates:
Before:
After:
Resolves #2513