Add explicit typealias to help with borrowing iterator PR#843
Merged
airspeedswift merged 1 commit intoswiftlang:mainfrom Dec 1, 2025
Merged
Add explicit typealias to help with borrowing iterator PR#843airspeedswift merged 1 commit intoswiftlang:mainfrom
airspeedswift merged 1 commit intoswiftlang:mainfrom
Conversation
This was referenced Nov 23, 2025
Member
Author
|
@swift-ci smoke test |
Member
Author
|
@swift-ci smoke test and merge |
Member
Author
|
Merging this since it's reasonable to make the type alias explicit even though it's not necessary. |
Member
Author
|
@swift-ci test macOS |
Member
|
@swift-ci test Linux |
natecook1000
approved these changes
Dec 1, 2025
slavapestov
reviewed
Dec 1, 2025
| /// An implementation of the Boyer-Moore-Horspool algorithm, for string-specific | ||
| /// searching. | ||
| struct SubstringSearcher: Sequence, IteratorProtocol { | ||
| typealias Element = Range<String.Index> |
Contributor
There was a problem hiding this comment.
May as well change Range<String.Index> below to Element also
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to be an issue affecting inference of associated types with swiftlang/swift#85294, which this works around