Fix compiler warnings in ByteCodeGen, Compiler, and Regex#854
Open
tshortli wants to merge 1 commit intoswiftlang:mainfrom
Open
Fix compiler warnings in ByteCodeGen, Compiler, and Regex#854tshortli wants to merge 1 commit intoswiftlang:mainfrom
tshortli wants to merge 1 commit intoswiftlang:mainfrom
Conversation
- Replace unused `let` bindings with `_` in ByteCodeGen+DSLList.swift - Replace unused `var codegen` with `_ =` in Compiler.swift - Add `@unknown default` to exhaustive switches on `AST.Node` in ASTConversion.swift - Fix unused bindings and no-effect `let` patterns in DSLTree.swift and ASTConversion.swift
tshortli
force-pushed
the
fix-warnings
branch
from
7b8e014 to
e77a026
Compare
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
letbindings with_in ByteCodeGen+DSLList.swiftvar codegenwith_ =in Compiler.swift@unknown defaultto exhaustive switches onAST.Nodein ASTConversion.swift since the switch enumerates cases from a library with library evolution in some build configurationsletpatterns in DSLTree.swift and ASTConversion.swift