Improve default Java home location and add testing for JavaVirtualMachine.shared#9
Merged
ktoso merged 16 commits intoswiftlang:mainfrom Mar 12, 2026
Merged
Conversation
ktoso
reviewed
Mar 12, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
This is a nice change, lgtm.
ktoso
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the location of the fallback system Java home into a
systemJavaHome()function, and adds a newJavaVirtualMachineTestswith a test to try loading the JVM and performing a simple class lookup and method invocation.We also add pre-installation of a JVM for various Linux CI runs in order to be able to execute the test. The test will be skipped, rather than failing, on systems where we don't currently pre-install a JVM (Windows, macOS) or on Android, where we don't yet support running tests within an apk.