Skip to content

Update lifetime dependence syntax#2564

Merged
meg-gupta merged 3 commits intomainfrom
updatelifetimesyntax
Mar 25, 2024
Merged

Update lifetime dependence syntax#2564
meg-gupta merged 3 commits intomainfrom
updatelifetimesyntax

Conversation

@meg-gupta
Copy link
Copy Markdown
Contributor

@meg-gupta meg-gupta commented Mar 24, 2024

Pitch - swiftlang/swift-evolution#2305

Update spellings to:
dependsOn(paramName...) and dependsOn(scoped paramName...) syntax

@meg-gupta
Copy link
Copy Markdown
Contributor Author

@swift-ci test

@meg-gupta
Copy link
Copy Markdown
Contributor Author

Please test with following pull request:
swiftlang/swift#72506

@swift-ci Please test

1 similar comment
@meg-gupta
Copy link
Copy Markdown
Contributor Author

Please test with following pull request:
swiftlang/swift#72506

@swift-ci Please test

@meg-gupta meg-gupta force-pushed the updatelifetimesyntax branch from 6419bb5 to a22fb3d Compare March 24, 2024 16:13
@meg-gupta
Copy link
Copy Markdown
Contributor Author

Please test with following pull request:
swiftlang/swift#72506

@swift-ci Please test

@meg-gupta
Copy link
Copy Markdown
Contributor Author

@swift-ci smoke test windows platform

@meg-gupta meg-gupta enabled auto-merge March 24, 2024 22:32
@meg-gupta meg-gupta merged commit ca20739 into main Mar 25, 2024
@meg-gupta meg-gupta deleted the updatelifetimesyntax branch March 25, 2024 00:55
Comment thread CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift
Comment thread CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift
Comment thread CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift
Comment thread CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift
Comment thread Sources/SwiftParser/Types.swift
SPECIFIER_PARSING: while canHaveParameterSpecifier {
if let (_, specifierHandle) = self.at(anyIn: SimpleTypeSpecifierSyntax.SpecifierOptions.self) {
specifiers.append(parseSimpleTypeSpecifier(specifierHandle: specifierHandle))
} else if self.at(TokenSpec(.dependsOn)) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified slightly to

} else if self.at(.keyword(.dependsOn)) {

meg-gupta added a commit that referenced this pull request Mar 25, 2024
meg-gupta added a commit that referenced this pull request Mar 25, 2024
meg-gupta added a commit that referenced this pull request Mar 25, 2024
meg-gupta added a commit that referenced this pull request Mar 25, 2024
meg-gupta added a commit that referenced this pull request Mar 26, 2024
meg-gupta added a commit that referenced this pull request Mar 26, 2024
meg-gupta added a commit that referenced this pull request Mar 27, 2024
Update lifetime dependence syntax
meg-gupta added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants