Fix(FormatRawStringLiteral): Prevent invalid hash removal from single-line multiline strings#3259
Closed
rickhohler wants to merge 1 commit intoswiftlang:mainfrom
Closed
Conversation
…-line multiline strings (Fixes SourceKit-LSP swiftlang#2465)
rickhohler
requested review from
ahoppen,
hamishknight,
hborla and
rintaro
as code owners
Author
|
Closing in favor of #3256 which addresses the same issue and was submitted earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
FormatRawStringLiteralwhere hashes were incorrectly removed from single-line string literals that use multiline quotes (e.g.,#"""hello"""#), resulting in invalid Swift syntax ("""hello""").Detailed changes
FormatRawStringLiteral.swiftto detect when a string's content is fully wrapped in quotes (handling the ambiguous parsing of#"""..."""#) and when a string uses"""delimiters but has no newlines.Fixes
Resolves swiftlang/sourcekit-lsp#2465.
Pre-PR Checklist
swift-format.FormatRawStringLiteralTest.swift.