Skip to content

Add explicit target dependency#3304

Merged
hamishknight merged 1 commit intoswiftlang:release/6.3.1from
SimplyDanny:patch-1
Apr 10, 2026
Merged

Add explicit target dependency#3304
hamishknight merged 1 commit intoswiftlang:release/6.3.1from
SimplyDanny:patch-1

Conversation

@SimplyDanny
Copy link
Copy Markdown
Contributor

@SimplyDanny SimplyDanny commented Mar 31, 2026

Same as #3195 for the 6.3.1 release.

  • Explanation: Adds an explicit dependency to SwiftDiagnostics to the SwiftWarningControl package to pass the --explicit-target-dependency-import-check build check.
  • Scope: It only makes the dependency explicit and --explicit-target-dependency-import-check pass. There is no change in dependencies.
  • Issues: Issue was reported in a comment on the same fix on main.
  • Original PRs: Add explicit target dependency #3195
  • Risk: None.
  • Testing: Not required.
  • Reviewers: @ahoppen, @hamishknight

Same as swiftlang#3195 for the 6.3.1 release.
@shahmishal
Copy link
Copy Markdown
Member

Please also cherry-pick this into release/6.3 branch.

@SimplyDanny
Copy link
Copy Markdown
Contributor Author

Please also cherry-pick this into release/6.3 branch.

#3307

@hamishknight
Copy link
Copy Markdown
Contributor

Could you please fill out the release nomination template in the PR description?

@hamishknight
Copy link
Copy Markdown
Contributor

@swift-ci please test

@SimplyDanny
Copy link
Copy Markdown
Contributor Author

Could you please fill out the release nomination template in the PR description?

Done.

Copy link
Copy Markdown
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hamishknight
Copy link
Copy Markdown
Contributor

@swift-ci please test Windows

@hamishknight hamishknight enabled auto-merge April 9, 2026 10:07
@hamishknight
Copy link
Copy Markdown
Contributor

@hamishknight hamishknight merged commit cef909d into swiftlang:release/6.3.1 Apr 10, 2026
99 of 102 checks passed
@SimplyDanny SimplyDanny deleted the patch-1 branch April 10, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants