Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
Add refactoring to inline function at function call.
Test cases are written for the same.
Scope:
This will provide refactoring to inline functions at function call and will be wired as a codeAction in sourcekit-lsp.
Issues:
swiftlang/sourcekit-lsp#2508
Original PRs:
Not Applicable
Risk:
This is a standalone feature and does not change the existing structure or functionality of the code.
It is a additional feature.
Testing:
Added unit tests covering:
All tests pass locally using
swift test.Reviewers:
Not Applicable