SILGen: Remove triplesAreValidForZippering() assert#76276
Merged
tshortli merged 1 commit intoswiftlang:mainfrom Sep 5, 2024
Merged
SILGen: Remove triplesAreValidForZippering() assert#76276tshortli merged 1 commit intoswiftlang:mainfrom
tshortli merged 1 commit intoswiftlang:mainfrom
Conversation
This assert was correctly catching the fact that `-target-variant` is not being normalized at the same time as `-target` when building arm64e modules from swiftinterface. That should be fixed, but at the moment it isn't causing any concrete harm and the assertion fails when building against the SDKs included with the latest Xcode 16 betas. Resolves rdar://133020098.
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assert was correctly catching the fact that
-target-variantis not being normalized at the same time as-targetwhen building arm64e modules from swiftinterface. That should be fixed, but at the moment it isn't causing any concrete harm and the assertion fails when building against the SDKs included with the latest Xcode 16 betas.Resolves rdar://133020098.