build.ps1: Update to NDK 28c, in preparation for the upcoming LTS NDK 30#87774
build.ps1: Update to NDK 28c, in preparation for the upcoming LTS NDK 30#87774finagolfin merged 1 commit intoswiftlang:mainfrom
Conversation
utils/build.ps1
Outdated
| @@ -475,11 +475,16 @@ $KnownNDKs = @{ | |||
There was a problem hiding this comment.
I can remove this old NDK too, if wanted.
There was a problem hiding this comment.
Yeah, lets remove r26b, we have been on r27c for a while.
|
This will break 4-5 tests when running the compiler validation suite for Android on the Windows x86_64 trunk snapshot CI, but we ignore those Android results and hundreds more are failing anyway atm. |
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
We need to ensure that this actually builds on swift.org CI and you've tested it locally?
utils/build.ps1
Outdated
| @@ -475,11 +475,16 @@ $KnownNDKs = @{ | |||
There was a problem hiding this comment.
Yeah, lets remove r26b, we have been on r27c for a while.
Also, update the prior option to the latest NDK 27d and remove 26b.
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
As long as this passes on CI and is in sync with the other Android builds, should be fine.
No way to test this before merging on Windows CI, but I tested it locally on linux and submitted it for the official Android trunk CI that runs on linux also, swiftlang/swift-docker#528, where you can see the five tests that fail. Once this is in, I will follow up with any fixes needed if it breaks the one post-merge CI that builds and tests the Android SDKs on Windows, which seems to have broken with some |
|
@swift-ci smoke test |
|
@Steelskin, is this something you can test on your CI? |
|
Hmm, strange lldb test failures on linux and mac, obviously unrelated to this Windows-only pull, flakes? @swift-ci smoke test linux |
|
Oh nice, Windows trunk snapshot toolchain CI passed again. @swift-ci smoke test macos |
|
@swift-ci smoke test linux |
|
@swift-ci smoke test macos |
|
@swift-ci smoke test linux |
|
@swift-ci smoke test macOS |
|
The first Windows trunk snapshot CI run with this NDK 28 showed no build errors: I will try NDK 29 next, once we get that wchar modularization issue fixed, #85365. |
2 participants
Also, update the prior option to the latest NDK 27d.
This poses no problem for any PR CI, which do not build for Android, but only the trunk snapshot CI, which we need to start getting ready for the upcoming LTS NDK release.