Open
Conversation
…AccessSystem API.
Improve person relationship handling by checking `parent_id` directly and setting `is_admin` during door access creation, and enhance test setup with schema deployment, fixture creation for 'The Door' and 'Donation' tier, and more robust tool creation.
…cluding a start script, database seeding, and setup instructions.
oestoer
force-pushed
the
oestoer/tests-in-ci
branch
from
87b6acd to
5d1022d
Compare
oestoer
commented
Jan 18, 2026
| if(!$self->parent) { | ||
| # Check parent_id column directly to avoid relationship resolution issues | ||
| # on newly created objects that haven't been stored yet | ||
| my $parent_id = $self->get_column('parent_id'); |
Member
Author
There was a problem hiding this comment.
Without the changes in this file, I was unable to get the tests working. Please check if it makes sense.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CI/CD pipelines and improves test reliability by introducing fixtures and configuration for isolated test environments.
Docker and Build System:
Continuous Integration and Deployment:
.github/workflows/ci.yaml) that builds and tests the app on each push or PR, and builds/pushes images to GHCR on release or master branch (.github/workflows/ci.yaml).depsstage for faster builds with dependency caching (.github/workflows/build-dev-image.yaml).Testing Improvements:
t/lib/AccessSystem/Fixtures.pm) to reliably set up membership tiers and required tools for tests, improving test reproducibility (t/lib/AccessSystem/Fixtures.pm).accesssystem_api_test.conf).Local Production Testing:
test-deploy/README.md).