Skip to content

deepclone_from_array: reject building an uninitialized object #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Jun 10, 2026
Merged

deepclone_from_array: reject building an uninitialized object #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions deepclone.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3365,6 +3365,15 @@ PHP_FUNCTION(deepclone_from_array)
}
class_ces[cid] = ce;
}
/* deepclone_to_array() always emits a class that has
* __unserialize() as a negative-wakeup state replay. A payload
* that creates such a class without that flag would leave the bare
* object_init_ex() shell uninitialized — e.g. BcMath\Number's
* bc_num stays NULL and any operation on it crashes. Reject rather
* than build an unusable object. */
if (UNEXPECTED(ce->__unserialize != NULL && (!obj_wakeups || obj_wakeups[id] >= 0))) {
DC_INVALID("deepclone_from_array(): Argument #1 ($data) object %u of class %s has an __unserialize() method but \"objectMeta\" does not flag it for an __unserialize state", id, ZSTR_VAL(ce->name));
}
if (UNEXPECTED(object_init_ex(&obj_zval, ce) != SUCCESS)) {
goto cleanup;
}
Expand Down
25 changes: 12 additions & 13 deletions tests/deepclone_bcmath_number.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--TEST--
deepclone round-trips BcMath\Number, refuses to hydrate it, and never crashes on an uninitialized one (symfony/symfony#64323)
deepclone round-trips BcMath\Number, refuses to hydrate it, and rejects a payload that would create an uninitialized one (symfony/symfony#64323)
--EXTENSIONS--
deepclone
--SKIPIF--
Expand Down Expand Up @@ -37,17 +37,19 @@ try {
echo $e->getMessage(), "\n";
}

// ── Defensive: an uninitialized instance (forced here via a hand-mutated
// payload that drops the __unserialize replay) must throw a clean Error on
// use, never segfault. ──
// ── A crafted payload that drops the __unserialize replay for a class that
// needs it (here by clearing the wakeup flag) is rejected, rather than
// building an uninitialized instance that would crash on use. An
// uninitialized BcMath\Number cannot be reached from userland, so the
// engine offers no guard; the extension must not produce one either. ──
$d = deepclone_to_array(new Number('1'));
$d['objectMeta'][0][1] = 0; // clear the __unserialize flag
$d['states'] = []; // and drop the replay
$u = deepclone_from_array($d);
var_dump($u instanceof Number);
foreach (['toString' => fn() => (string) $u, 'clone' => fn() => clone $u, 'add' => fn() => $u->add(1)] as $op => $f) {
try { $f(); echo "$op: no error\n"; }
catch (\Error $e) { echo "$op: ", $e->getMessage(), "\n"; }
try {
deepclone_from_array($d);
echo "not rejected\n";
} catch (\ValueError $e) {
echo "rejected with ValueError\n";
}
?>
--EXPECT--
Expand All @@ -62,7 +64,4 @@ string(6) "99.999"
int(3)
string(7) "100.499"
Class "BcMath\Number" is not instantiable.
bool(true)
toString: The BcMath\Number object has not been correctly initialized by its constructor
clone: The BcMath\Number object has not been correctly initialized by its constructor
add: The BcMath\Number object has not been correctly initialized by its constructor
rejected with ValueError