Advise trusting the input in the allow_named_closures refusal message#28
Merged
Conversation
deepclone_to_array() refuses to serialize a closure over a named callable unless allow_named_closures is set. The message now quotes the option and adds that it should be enabled only for trusted input, since a by-name payload can mint a Closure over any function or method of that name. This mirrors the polyfill's wording (symfony/polyfill#635), which additionally points at this extension; the extension does not suggest installing itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deepclone_to_array()refuses to serialize a closure over a named callable unlessallow_named_closuresis set. The refusal message now quotes the option and adds that it should be enabled only for trusted input, since a by-name payload can mint aClosureover any function or method of that name (including internal functions likesystem()):This mirrors the polyfill's wording (symfony/polyfill#635), which additionally suggests installing this extension — the extension does not suggest installing itself. The leading part of the message is unchanged up to
requires enabling the, so the shared substring the polyfill's dual-implementation tests match on still holds.The three
.phpts asserting the message are updated; thedeepclone_from_array()("resolving") refusal is left as-is, matching the polyfill.