[DeepClone] Reject from_array payloads that would build an uninitialized object#631
Merged
Merged
Conversation
…zed object deepclone_to_array() always emits a class that has __unserialize() as a negative-wakeup state replay. A crafted deepclone_from_array() payload that flags such a class for plain creation (wakeup >= 0, no replay) was reconstructed as an uninitialized object: the polyfill returned null. reconstruct() now rejects such a payload with a \ValueError before building the object, matching the extension (symfony/php-ext-deepclone#22). Well-formed payloads always carry the negative-wakeup replay for an __unserialize class, so they are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the polyfill in line with the extension's symfony/php-ext-deepclone#22.
deepclone_to_array()always emits a class that has__unserialize()as a negative-wakeup state replay. A crafteddeepclone_from_array()payload that flags such a class for plain creation (wakeup >= 0, no replay) was reconstructed as an uninitialized object: the polyfill returnednull, while the extension (before #22) built a bare shell, e.g. aBcMath\Numberwhosebc_numstaysNULLand crashes on use.reconstruct()now rejects such a payload with a\ValueErrorbefore building the object, using the same message as the extension. Well-formed payloads, which always carry the negative-wakeup replay for an__unserializeclass, are unaffected.