fix: handle ProcessTimedOutException and ProcessSignaledException in SymfonyProcessRunner#56
fix: handle ProcessTimedOutException and ProcessSignaledException in SymfonyProcessRunner#56jordanpartridge wants to merge 1 commit intomasterfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Coverage Report
Files Below Threshold
🏆 Synapse Sentinel Gate |
🔧 Synapse Sentinel: 2 checks need attentionThe following issues must be resolved before this PR can be merged: Test Failures (1 total)Fix these failing tests: 1. CertifyCommand → handle → it stops at first failure when stop-on-fa… 0.38sFAIL at Fix: Review the test expectation vs actual behavior. Check the tested code logic. Security AuditReview the output and fix any issues.Quick Reference:
🤖 Generated by Synapse Sentinel - View Run |
…SymfonyProcessRunner Wrap Process::run() in try/catch to gracefully handle timeout and signal exceptions. Returns a failed ProcessResult instead of letting exceptions propagate uncaught through callers. - ProcessTimedOutException → exit code 124 - ProcessSignaledException → exit code from process or 137 - Add tests for both exception paths - Run pint (style fixes in 5 additional files) Closes #50
fafe479 to
2cb4d91
Compare
🔧 Synapse Sentinel: 2 checks need attentionThe following issues must be resolved before this PR can be merged: All tests passed.--- Security AuditReview the output and fix any issues.Quick Reference:
🤖 Generated by Synapse Sentinel - View Run |
Summary
Process::run()in try/catch to handleProcessTimedOutExceptionandProcessSignaledExceptiongracefullyProcessResultinstead of letting exceptions propagate uncaught through TestRunner, SecurityScanner, and commandsProcessTimedOutExceptionreturns exit code 124 with descriptive messageProcessSignaledExceptionreturns exit code from process (or 137 fallback)Test plan
vendor/bin/pint(fixed style in 5 additional files)Closes #50