fix: add postActionablePrompt tests and logError type safety#58
fix: add postActionablePrompt tests and logError type safety#58jordanpartridge wants to merge 1 commit intomasterfrom
Conversation
Add 7 tests for postActionablePrompt() covering all paths: not available, no PR number, empty prompt, success, API error, 403, and 429 responses. Fix logError() type safety by adding instanceof RequestException check before calling hasResponse(), which only exists on RequestException, not on the GuzzleException interface. ChecksClient coverage: 89.1% → 100%
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Coverage Report
Files Below Threshold
🏆 Synapse Sentinel Gate |
🔧 Synapse Sentinel: 2 checks need attentionThe following issues must be resolved before this PR can be merged: All tests passed.--- Security AuditReview the output and fix any issues.Quick Reference:
🤖 Generated by Synapse Sentinel - View Run |
Summary
postActionablePrompt()covering all code paths (not available, no PR number, empty prompt, success, API error, 403, 429)logError()type safety: addinstanceof RequestExceptioncheck before callinghasResponse(), which only exists onRequestException, not on theGuzzleExceptioninterfaceCoverage
ChecksClientcoverage: 89.1% → 100%Test plan
pest --filter=ChecksClient --coverageshows 100% for ChecksClientCloses #46