refactor: inject ProcessRunner into CheckCommand#62
refactor: inject ProcessRunner into CheckCommand#62jordanpartridge wants to merge 1 commit intomasterfrom
Conversation
Replace hardcoded `new Process()` calls with the existing ProcessRunner contract, aligning CheckCommand with the architecture used by TestRunner and SecurityScanner. Add withMocks() pattern for testability. Create CheckCommandTest.php with 23 tests covering all branches: handle orchestration, skip flags, coverage parsing, PHPStan JSON handling, style checks, all 3 output formats, and verdict determination. Closes #49
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Coverage Report
Files Below Threshold
🏆 Synapse Sentinel Gate |
🔧 Synapse Sentinel: 2 checks need attentionThe following issues must be resolved before this PR can be merged: All tests passed.--- Security AuditReview the output and fix any issues.Quick Reference:
🤖 Generated by Synapse Sentinel - View Run |
Summary
new Process()calls with the existingProcessRunnercontract, aligningCheckCommandwith the architecture used byTestRunnerandSecurityScannerwithMocks()pattern for testability (matchingTestsCommand/CertifyCommandconventions)tests/Unit/Commands/CheckCommandTest.phpwith 23 tests covering all branches: handle orchestration, skip flags, coverage parsing, PHPStan JSON handling, style checks, all 3 output formats, and verdict determinationTest plan
Closes #49
🤖 Generated with Claude Code