add --ignore-env to exec#1368
Open
synfinatic wants to merge 11 commits into
Open
Conversation
update readme
Apparently some AWS SSO instances throw an API error if the client tries to register using both device_code and authorization_code. This change forces the client to always register one or the other + refresh_token support. Existing clients which have support for all 3 will be re-registed with 2. Fixes: #1359
Support device_code or authorization_code, not both
do not support go install
Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 20 to 23. - [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases) - [Commits](DavidAnson/markdownlint-cli2-action@v20...v23) --- updated-dependencies: - dependency-name: DavidAnson/markdownlint-cli2-action dependency-version: '23' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tarides/changelog-check-action](https://github.com/tarides/changelog-check-action) from 2 to 3. - [Release notes](https://github.com/tarides/changelog-check-action/releases) - [Commits](tarides/changelog-check-action@v2...v3) --- updated-dependencies: - dependency-name: tarides/changelog-check-action dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…rides/changelog-check-action-3 Bump tarides/changelog-check-action from 2 to 3
…vidAnson/markdownlint-cli2-action-23 Bump DavidAnson/markdownlint-cli2-action from 20 to 23
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an aws-sso exec flag intended to support nested executions where the parent process sets AWS credential environment variables (e.g., helm invoking kubectl exec auth plugins), addressing issue #1095.
Changes:
- Add
--ignore-env(-i) flag toaws-sso execto bypass the existing AWS env conflict check. - Update
CHANGELOG.mdto document the new flag.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/aws-sso/exec_cmd.go | Adds an IgnoreEnv option and skips checkAwsEnvironment() when set. |
| CHANGELOG.md | Adds an Unreleased entry mentioning exec --ignore-env. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+54
to
+58
| if !ctx.Cli.Exec.IgnoreEnv { | ||
| err := checkAwsEnvironment() | ||
| if err != nil { | ||
| log.Fatal("Unable to continue", "error", err.Error()) | ||
| } |
Comment on lines
+6
to
+9
| ### New Features | ||
|
|
||
| * Add aws-sso exec --ignore-env flag to allow overriding AWS_ env variables #1095 | ||
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.3.0-dev #1368 +/- ##
==============================================
+ Coverage 88.50% 88.52% +0.02%
==============================================
Files 54 54
Lines 3643 3649 +6
==============================================
+ Hits 3224 3230 +6
Misses 289 289
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Fixes: #1095
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1095