Merged
Conversation
Add closeEvent override that cleans up the temporary download directory when the install preview window is closed. Previously the temp dir created by PreviewWorker via tempfile.mkdtemp() was never removed. Also replaced the unused tempfile.TemporaryDirectory field with the str path that was actually being used.
The download progress dialog had a Cancel button but the canceled signal was never connected. Clicking Cancel now closes the dialog and ignores the download result when it completes.
Add auto_update_interval_hours config field (default: 24 hours, 0 to disable). TrayScreen starts a QTimer that triggers the existing _on_check_updates handler at the configured interval. The timer is restarted when update source or channel settings change. Also extract menu building into _build_menu to keep __init__ under the statement limit.
Delete synodic_client/schema.py which contained VersionInformation, UpdateChannel (StrEnum), UpdateStatus, UpdateCheckResult, and UpdateProgress none were used outside of __init__.py re-exports. The canonical UpdateChannel in updater.py is now a StrEnum (was Enum/auto), replacing the duplicate definition. UpdateState remains as the single status enum. Cleans up __init__.py exports to only re-export types from updater.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.