Upgrade sylius 2.0

[jbcr]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	yes
Fixed issue	#63

Upgrade for Sylius 2.0 and Symfony 6.4 and ^7.0

Drop Sylius 1.x support

Drop Symfony 5.x support

[jbcr]

The result in admin interface:

[maxperei]

thank you very much for your contribution @jbcr and well done 🫰

tests are not passing as you probably notice since you changed annotation to attribute you have to edit tests/PHPUnit/Fixtures/Foo.php to use php attribute

<?php

declare(strict_types=1);

namespace Tests\Synolia\SyliusGDPRPlugin\PHPUnit\Fixtures;

use Synolia\SyliusGDPRPlugin\Attribute\Anonymize;

class Foo
{
    #[Anonymize(['faker' => 'email'])]
    public $email = '';

    #[Anonymize(['value' => 'test-annonation-value'])]
    public $value;

    #[Anonymize(['value' => 'test-annonation-value-without-property'])]
    public $valueWithoutProperty;

    #[Anonymize(['faker' => 'email', 'prefix' => 'test-annotation-prefix-'])]
    public $prefix;

    #[Anonymize(['value' => 'value', 'prefix' => 'test-annotation-prefix-value-'])]
    public $prefixValue;

    #[Anonymize(['value' => 'attribute'])]
    public $mergeYamlAnnotationConfiguration;

    #[Anonymize(['value' => ['value1', 'value2']])]
    public array $arrayValue;

    #[Anonymize(['value' => '1542', 'prefix' => '1542'])]
    public int $integer;

    public $bar;
}

but this may not correct yet because configuration yaml is not merged anymore maybe we'll have to investigate on this..

the remaining is just about code style and some tiny stuff but this a great beginning

[jbcr]

but this may not correct yet because configuration yaml is not merged anymore maybe we'll have to investigate on this..

the remaining is just about code style and some tiny stuff but this a great beginning

What is the configuration loader priority?

The attribute configuration overrides the YAML configuration. But sometimes, the loader is in a different order and the test works.

I propose using the tag priority to set the loader order and fix this error.

[maxperei]

but this may not correct yet because configuration yaml is not merged anymore maybe we'll have to investigate on this..
the remaining is just about code style and some tiny stuff but this a great beginning

What is the configuration loader priority?

The attribute configuration overrides the YAML configuration. But sometimes, the loader is in a different order and the test works.

I propose using the tag priority to set the loader order and fix this error.

sure @jbcr, LoaderChain put AttributeLoader at the end so unfortunately mergeYamlAnnotationConfiguration is not overriden but idk why because previous AnnotationLoader was loaded at the first position 🤷 btw it's a good idea to use tag priority to control that
and beyond that it will be amazing to replace CompilerPass/RegisterAnonymizationLoader.php into a #[AutowireIterator] php attribute, i'll be glad if i could help

[jbcr]

sure @jbcr, LoaderChain put AttributeLoader at the end so unfortunately mergeYamlAnnotationConfiguration is not overriden but idk why because previous AnnotationLoader was loaded at the first position 🤷 btw it's a good idea to use tag priority to control that and beyond that it will be amazing to replace CompilerPass/RegisterAnonymizationLoader.php into a #[AutowireIterator] php attribute, i'll be glad if i could help

It's changed and all tests pass.

[maxperei]

looks wonderful now many thx @jbcr