Open
Conversation
Member
oallain
commented
Jan 20, 2024
oallain
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Fixed issue | #92 |
| License | MIT |
oallain
force-pushed
the
fix/#92-live-logs
branch
from
0616a70 to
5b5c91e
Compare
|
|
timmess
force-pushed
the
fix/#92-live-logs
branch
7 times, most recently
from
92773d7 to
e4e434b
Compare
[Feat] Better command interruption management
oallain
force-pushed
the
fix/#92-live-logs
branch
from
e4e434b to
4af25c3
Compare
* Add possibility of time date format 12/24 and drop Sylius 1.10 support * Try to fix makefile that were messing with CI * use php attribute --------- Co-authored-by: Olivier ALLAIN <olivier.allain@synolia.com>
Define a different timezone for scheduled tasks
oallain
force-pushed
the
fix/#92-live-logs
branch
from
4af25c3 to
436b012
Compare
maxperei
reviewed
Mar 24, 2025
| cp -R vendor/synolia/sylius-scheduler-command-plugin/install/Application/config/packages/* config/packages/ | ||
| cp -R vendor/synolia/sylius-scheduler-command-plugin/install/Application/config/routes/* config/routes/ | ||
|
|
||
| 6. Installing assets (JS and CSS) fot the plugin |
There was a problem hiding this comment.
Suggested change
| 6. Installing assets (JS and CSS) fot the plugin | |
| 6. Installing assets (JS and CSS) for the plugin |
| ${CONSOLE} sylius:fixtures:load default -n | ||
| ${YARN} install | ||
| ${YARN} build | ||
| ${CONSOLE} assets:install -n |
There was a problem hiding this comment.
i'm wondering if composer req does not already play this command at auto-scripts 🤔
Member
Author
|
Hello @maxperei Should we keep this PR (update it) and merge it into the Sylius 1.x-compatible version? |
Member
|
@oallain yes, maybe a patch version for 1.X should be great |
Member
|
I tried to change the target branch, but I guess a rebase is needed 😮💨 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.