Skip to content

Conversation

@jvsena42
Copy link
Member

@jvsena42 jvsena42 commented Jan 20, 2026

Fixes #651
Fixes #658

This PR fixes multiple issues with the foreground notification in LightningNodeService:

Description

  1. Makes the notification non-dismissable by adding .setOngoing(true)
  2. Handles Android 15+ foreground service timeout by implementing onTimeout() callback
  3. Improves the notification icon and adds brand color for better visibility
  4. Removes redundant duplicate startForeground() call

Preview

api-level-36.webm
api-level-33.webm

QA Notes

1. Non-dismissable notification

  1. Open the app with a configured wallet
  2. Pull down the notification shade
  3. Try to swipe away the "Bitkit is running" notification
  4. Node: on API level 33+ (android 13) it is possible to hide ongoing notifications, see preview

2. Notification appearance

  1. Check the notification in the notification shade
  2. Verify: Icon is recognizable with brand orange color (#FF4400)

3. Android 15+ timeout handling (optional)

To test the FGS timeout on Android 15 (not above):

adb shell am compat enable FGS_INTRODUCE_TIME_LIMITS to.bitkit
adb shell device_config put activity_manager data_sync_fgs_timeout_duration 60000

Wait 60 seconds and verify the service stops gracefully without crash.

@jvsena42 jvsena42 self-assigned this Jan 20, 2026
@jvsena42 jvsena42 marked this pull request as ready for review January 20, 2026 20:19
@claude

This comment has been minimized.

@ovitrif

This comment was marked as resolved.

@claude

This comment was marked as resolved.

@claude
Copy link

claude bot commented Jan 20, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@jvsena42 jvsena42 requested a review from ovitrif January 20, 2026 20:56
@jvsena42
Copy link
Member Author

Still not tested the adb commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App running in background notification is dismiss-able [UI]: Background receive payment notification icon is unrecognisable

3 participants