Incr23 24 #13
Open
Incr23 24 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bambruysk
suggested changes
Dec 15, 2022
bambruysk
left a comment
bambruysk
left a comment
There was a problem hiding this comment.
Нужно дорабоать в части возврата ошибок из grpc
config/config.go
Outdated
|
|
||
| func withGrpcAddress(address string) Option { | ||
| return func(s *Config) { | ||
| if host, port, err := net.SplitHostPort(address); err == nil { |
There was a problem hiding this comment.
Слишком большая вложенность - это не go-way. Лучше классическое if err != nil {return}
proto/service.proto
Outdated
|
|
||
| message UpdateMetricResponse { | ||
| MetricMessage metric = 1; | ||
| string error = 2; |
There was a problem hiding this comment.
лучше для возвращения ошибки bспользовать библиотеку grpc/status
proto/service.proto
Outdated
|
|
||
| message MetricMessage { | ||
| string name = 1; | ||
| string type = 2; |
proto/service.proto
Outdated
| message MetricMessage { | ||
| string name = 1; | ||
| string type = 2; | ||
| optional uint64 counter = 3; |
There was a problem hiding this comment.
А здесь явно напрашиввается oneof - тогда и type не нужен
internal/app/client.go
Outdated
| log.Fatal(err) | ||
| } | ||
|
|
||
| defer func(conn *grpc.ClientConn) { |
bambruysk
approved these changes
Dec 23, 2022
| var response pb.UpdateMetricResponse | ||
|
|
||
| err := metric.Check() | ||
| if err, ok := err.(validator.ValidationErrors); ok { |
There was a problem hiding this comment.
А если это не ошибка валидации, а еще какая-то? Нет я догадываются тчо другиз там и нет, но тогда зачем это приведение? Подозрительнгео место
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.