Allow innit to take in env variables #8320
Draft
+373
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-si-settings
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
nickgerace
force-pushed
the
nick/3adcc0a
branch
2 times, most recently
from
c652fb0 to
bd4b528
Compare
This changes allows innit to take in env variables. This can be configured by environment variable or command line argument with the new "mode" type. It contains two variants: "env" and "ssm". If the mode is not provided, it defaults to "ssm", which ensures innit runs as it does on main today. If "env" is provided, then innit will take in environment variables to configure all services rather than using ssm. The environment variable use case may not be that interesting on its own, but innit being able to be used across several verticals and cloud providers in the future helps standardize the SI initialization procedure. Theorhetically, a secrets manager provided by a helm chart on a k8s cluster can do the same thing. For now, innit's env var use case is valuable. We'll see how long that will remain to be the case. Signed-off-by: Nick Gerace <nick@systeminit.com>
nickgerace
force-pushed
the
nick/3adcc0a
branch
from
bd4b528 to
f58bd6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.