AI Support by josejuanmontiel · Pull Request #174 · syumai/workers

josejuanmontiel · 2025-04-21T11:59:24Z

What

Add initial support for all AI stuff in workers

Motivation

It was a no-implemented feature, as an example of implementation take kv and create an initial aproach.

josejuanmontiel · 2025-04-21T12:20:32Z

Take this part of the conversation: "Also, instead of creating a separate mock package, please put both implementations in the same directory (e.g., foo.go and foo_js.go)" in this PR.

syumai

Thank you for PR! Please check comments.

syumai · 2025-04-21T12:41:34Z

_examples/ai/README.md

@@ -0,0 +1,57 @@
+# worker-template-go


Please refer to other examples and update your README 🙏

syumai · 2025-04-21T12:42:43Z

_examples/ai/go.mod

+
+go 1.22.2
+
+require github.com/syumai/workers v0.28.1


Suggested change

require github.com/syumai/workers v0.28.1

require github.com/syumai/workers v0.0.0

syumai · 2025-04-21T12:42:57Z

_examples/ai/main.go

+	"strings"
+
+	"github.com/syumai/workers"
+	ai "github.com/syumai/workers/cloudflare/ai"


Suggested change

ai "github.com/syumai/workers/cloudflare/ai"

"github.com/syumai/workers/cloudflare/ai"

syumai · 2025-04-21T12:43:25Z

_examples/ai/main.go

+		// initialize AI namespace instance
+		aiCaller, err := ai.NewNamespace("AI")
+		if err != nil {
+			fmt.Fprintf(os.Stderr, "failed to init KV: %v", err)


Suggested change

fmt.Fprintf(os.Stderr, "failed to init KV: %v", err)

fmt.Fprintf(os.Stderr, "failed to init AI instance: %v", err)

syumai · 2025-04-21T12:43:40Z

_examples/ai/main.go

+		aiCaller, err := ai.NewNamespace("AI")
+		if err != nil {
+			fmt.Fprintf(os.Stderr, "failed to init KV: %v", err)
+			os.Exit(1)


I think os.Exit(1) doesn't have the desired effect. The existing KV example was wrong. Sorry 🙏

Suggested change

os.Exit(1)

return

syumai · 2025-04-21T13:00:10Z

cloudflare/ai/call_js.go

+//   - variable name must be defined in wrangler.toml as kv_namespace's binding.
+//   - if the given variable name doesn't exist on runtime context, returns error.
+//   - This function panics when a runtime context is not found.
+func NewNamespace(varName string) (*AI, error) {


Because the type name of instance is AI and the package name is same: ai, this function should be named just New.
See: https://go.dev/doc/effective_go#:~:text=Similarly%2C%20the%20function,ring.New.

Similarly, the function to make new instances of ring.Ring—which is the definition of a constructor in Go—would normally be called NewRing, but since Ring is the only type exported by the package, and since the package is called ring, it's called just New, which clients of the package see as ring.New.

syumai · 2025-04-21T13:02:14Z

cloudflare/ai/call_js.go

+	return &AI{instance: inst}, nil
+}
+
+func (ns *AI) WaitUntil(task func()) {


This method seems not used in example. Is this necessary?

syumai · 2025-04-21T13:11:49Z

cloudflare/ai/call_js.go

+}
+
+func (ns *AI) Run(key string, opts map[string]interface{}) (string, error) {
+	p := ns.instance.Call("run", key, mapToJS(opts, "text"))


Please add a link to the documentation for the text option.

syumai · 2025-04-21T13:11:55Z

cloudflare/ai/call_js.go

+// GetReader gets stream value by the specified key.
+//   - if a network error happens, returns error.
+func (ns *AI) RunReader(key string, opts map[string]interface{}) (io.Reader, error) {
+	p := ns.instance.Call("run", key, mapToJS(opts, "stream"))


Please add a link to the documentation for the stream option.

I add a few new examples... and in the last /ai-image-to-image that use returned this... "data: {"0":137,"1":80,"2":78,"3":71,"4":13,"5":10,"6":26,"7":10,"8":0,"9":0,"10":0,"11":13,"12":73,"13":72..." using this https://developers.cloudflare.com/workers-ai/models/stable-diffusion-v1-5-img2img/ and stream option... i leave comented a code (that doesnt work fully) to download the "stream"... i'm still learning how works all of this.. seeing this doc .. can you point where to find (and how to "solve") the stream option... i try to find something similiar in other place of the library .. .but no sure...

syumai · 2025-04-21T13:13:19Z

cloudflare/ai/call_js.go

+	})))
+}
+
+func mapToJS(opts map[string]interface{}, type_ string) js.Value {


Please use any instead of interface{}. (The same applies to other places.)

syumai · 2025-04-21T13:23:10Z

_examples/ai/wrangler.jsonc

+ */
+{
+	"$schema": "node_modules/wrangler/config-schema.json",
+	"name": "workers-ia",


Suggested change

"name": "workers-ia",

"name": "workers-ai-example",

b0ch3nski · 2025-05-02T20:27:24Z

cloudflare/ai/call.go

+}
+
+func New(varName string) (*AI, error) {
+	fmt.Println("NewNamespace called with varName:", varName)


using fmt.Println makes this a verbose logging that cannot be turned off - maybe consider using slog since it is in a standard library? :)

i put for my debug... i remove as in other part of the library...

b0ch3nski · 2025-05-02T20:28:29Z

_examples/ai/main.go

+		// }
+		// reader := strings.NewReader(string(aiResultStr))
+
+		// // Leer todo como string


Is this commented code a valuable snippet? If so, can you write the comments in English?

Hi! (as comented in discord) i leave this part as "incomplete" example of how to decode the return from this ai worker from cloudfare ... waiting to @syumai to help to discover how to treat "this sreaming response" to transleate a real image.... take a look at this part ... https://github.com/syumai/workers/pull/174/files/2ea1211dc55274f32cd979b860c753aa9cfcc8bf#r2054969323 where i comment the result and want help for how to decode this response to a real image...

update the comments for wait help :)

b0ch3nski · 2025-05-03T16:47:02Z

_examples/ai/package.json

@@ -0,0 +1,14 @@
+{
+	"name": "workers-ia",


I believe this @syumai comment is still valid

b0ch3nski · 2025-05-03T16:47:50Z

_examples/ai/Makefile

+.PHONY: build
+build:
+	go run ../../cmd/workers-assets-gen
+	tinygo build -o ./build/app.wasm -target wasm -no-debug ./...


All other examples are using "big Go" by default now 🙂

about this... apart from the differents in the compilation less space (dont know if big go support more things than tynygo... suppouse not) i was playing with adding in package json a "prebuild": "bash scripts/setup-tinygo.sh", that download the latest version of tinygo (it can be done in cloudfare) and execute later with "$(pwd)/_tinygo/bin/tinygo build -o ./build/app.wasm -target wasm -no-debug ./..." i used "_tinygo" as folder to download to skip this folder from go compilation :)

change name... but seems in all the examples Makefile use tinygo i'll leave the same... if you dont mind

After #175 has been merged, all examples are in Go 🙂

#175 is merged.

So I hope that this PR is picked up again :)

josejuanmontiel added 2 commits April 21, 2025 13:57

Adding ai stuff

92b0b61

renaming files and import

2ea1211

syumai reviewed Apr 21, 2025

View reviewed changes

josejuanmontiel added 14 commits April 21, 2025 17:48

updated as other example readme

3e67fb0

update version

ac0f467

change name

6aca119

remove unussed

307967a

organize import, message and var names

b46e9b5

removed

71cc4fa

remove comments

323bd4f

remane

565d8fa

not used

e3520f6

Change reference, constructor and example

bae90eb

WIP

db38cf2

playing with new models

588d708

Remove unused function ... and comments ... for later...

146aba9

Update doc

cd443b4

b0ch3nski reviewed May 2, 2025

View reviewed changes

josejuanmontiel added 2 commits May 3, 2025 10:05

remove log waiting to global aproach.

be67de1

correct the comment

173d910

b0ch3nski reviewed May 3, 2025

View reviewed changes

josejuanmontiel added 3 commits May 5, 2025 21:54

Merge branch 'main' into feat/ai_only

c170cb1

updated to big go

d8a2cca

update name

23c9d4e

josejuanmontiel requested review from b0ch3nski and syumai May 9, 2025 16:15

	require github.com/syumai/workers v0.28.1
	require github.com/syumai/workers v0.0.0

	ai "github.com/syumai/workers/cloudflare/ai"
	"github.com/syumai/workers/cloudflare/ai"

	fmt.Fprintf(os.Stderr, "failed to init KV: %v", err)
	fmt.Fprintf(os.Stderr, "failed to init AI instance: %v", err)

Conversation

josejuanmontiel commented Apr 21, 2025

What

Motivation

Uh oh!

josejuanmontiel commented Apr 21, 2025

Uh oh!

syumai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

syumai Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

josejuanmontiel May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

syumai Apr 21, 2025 •

edited

Loading

josejuanmontiel May 4, 2025 •

edited

Loading