Skip to content

d1: fix RowsAffected() in sql.Result implementation #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syumai merged 1 commit into from
Oct 21, 2025
Merged

d1: fix RowsAffected() in sql.Result implementation #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions cloudflare/d1/result.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,32 @@ package d1

import (
"database/sql"
"errors"
"fmt"
"syscall/js"
)

type result struct {
resultObj js.Value
}

var (
_ sql.Result = (*result)(nil)
)
var _ sql.Result = (*result)(nil)

// LastInsertId returns id of result's last row.
// If lastRowId can't be retrieved, this method returns error.
// If 'last_row_id' can't be retrieved, this method returns error.
func (r *result) LastInsertId() (int64, error) {
v := r.resultObj.Get("meta").Get("last_row_id")
if v.IsNull() || v.IsUndefined() {
return 0, errors.New("d1: lastRowId cannot be retrieved")
}
id := v.Int()
return int64(id), nil
return r.numberFromMeta("last_row_id")
}

// RowsAffected returns the number of rows affected by an update, insert, or delete.
// If 'changes' can't be retrieved, this method returns error.
func (r *result) RowsAffected() (int64, error) {
return int64(r.resultObj.Get("changes").Int()), nil
return r.numberFromMeta("changes")
}

func (r *result) numberFromMeta(key string) (int64, error) {
v := r.resultObj.Get("meta").Get(key)
if v.IsNull() || v.IsUndefined() {
return 0, fmt.Errorf("d1: '%s' cannot be retrieved", key)
}
return int64(v.Int()), nil
}
Loading