Open
Conversation
neufeldtech
force-pushed
the
email
branch
4 times, most recently
from
7109236 to
28fe6b0
Compare
reorder functions
Author
|
@syumai what are your recommendations for testing strategy for these types of APIs? I looked briefly into some of the queues tests, but many of the other pieces have no tests 🤔 |
b0ch3nski
reviewed
Dec 9, 2025
Contributor
b0ch3nski
left a comment
b0ch3nski
left a comment
There was a problem hiding this comment.
Thanks for working on this! Just some minor nitpicks 🙂
Author
|
@syumai - you able to review this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds email handling functionality.
Motivation
This feature was not implemented yet and I would rather write email workers in golang than Typescript.