fix: set session as gracefully closing on goaway frame#90
fix: set session as gracefully closing on goaway frame#90mkaufmaner wants to merge 3 commits intoszmarczak:masterfrom
Conversation
mkaufmaner
force-pushed
the
89-handle-goaway-frame
branch
from
207e275 to
51eeaf5
Compare
|
@szmarczak I am not really sure how to create a test for this specific use case, but I will continue to try. |
source/agent.js
Outdated
| session.once('goaway', () => { | ||
| // Prevent session from being used for new requests. | ||
| // The session will eventually emit either an 'error' or 'close' event. | ||
| session[kGracefullyClosing] = true; |
There was a problem hiding this comment.
Please use gracefullyClose(session) instead
There was a problem hiding this comment.
Can you add a comment to the spec as well please?
There was a problem hiding this comment.
@szmarczak My only concern with using gracefullyClose(session) is that session.close() may be fired multiple times but this condition appears to be handled here so I will update it to use gracefullyClose.
As for the spec, do you mean the comment in the source code?
There was a problem hiding this comment.
Does this work?
// See https://datatracker.ietf.org/doc/html/rfc7540#section-6.8
// There is an inherent race condition between an endpoint starting new streams and the remote sending a GOAWAY frame.
// Receivers of a GOAWAY frame MUST NOT open additional streams on the connection, although a new connection can be established for new streams.There was a problem hiding this comment.
Change made to reference RFC
There was a problem hiding this comment.
@szmarczak Do you need me to do anything else for this?
|
No worries, I'll create one |
Thank you! Not familiar with the ava testing framework. |
|
@szmarczak Bump :) |
3 participants
Closes #89