Conversation
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
+ Coverage 63.3% 67.0% +3.6%
=======================================
Files 34 42 +8
Lines 4907 5518 +611
Branches 443 512 +69
=======================================
+ Hits 3110 3701 +591
Misses 1651 1651
- Partials 146 166 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
| EnvelopeAssemblyComponent, | ||
| ) | ||
| from epinterface.sbem.flat_constructions.materials import ( | ||
| CEMENT_MORTAR, |
There was a problem hiding this comment.
I wonder if the materials and their quantities can still be part of the configurations an inputs as well, unless we are collectively exhaustive here
|
|
||
|
|
||
| def build_partition_assembly( | ||
| *, name: str = "Partition" |
There was a problem hiding this comment.
I think this needs to be more flexible/handle the boundaries of E+ constructions / what is possible to model in E+. I can test the boundaries a bit!
| for structural_system, template in WALL_STRUCTURAL_TEMPLATES.items(): | ||
| if template.supports_cavity_insulation and template.cavity_depth_m is not None: | ||
| max_cavity_r = template.cavity_depth_m / FIBERGLASS_BATTS.Conductivity | ||
| audit_cavity_r = min(2.0, max_cavity_r * 0.9) |
There was a problem hiding this comment.
where does the 0.9 come from?
4 participants
Add a semi-flat wall construction representation for improved expressivity and ML-friendly feature generation.