Skip to content

Comments

Flat_reconstruction assembly classes#62

Draft
szvsw wants to merge 1 commit intocursor/semi-flat-wall-constructions-2cb3from
cursor/flat-reconstruction-assembly-classes-5a36
Draft

Flat_reconstruction assembly classes#62
szvsw wants to merge 1 commit intocursor/semi-flat-wall-constructions-2cb3from
cursor/flat-reconstruction-assembly-classes-5a36

Conversation

@szvsw
Copy link
Owner

@szvsw szvsw commented Feb 25, 2026

Refactor flat_constructions modules to use class-based assembly strategies.

This refactor moves construction layup logic from conditional blocks into polymorphic builder subclasses, making it easier to customize layups for each assembly type. STRUCTURAL_TEMPLATES are preserved for backward compatibility.


Open in Web Open in Cursor 

Co-authored-by: Sam Wolk <szvsw@users.noreply.github.com>
@cursor
Copy link

cursor bot commented Feb 25, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 89.36170% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.8%. Comparing base (a136df7) to head (92f34a6).

Files with missing lines Patch % Lines
epinterface/sbem/flat_constructions/roofs.py 86.4% 8 Missing and 5 partials ⚠️
epinterface/sbem/flat_constructions/walls.py 90.6% 5 Missing and 5 partials ⚠️
epinterface/sbem/flat_constructions/slabs.py 91.1% 4 Missing and 3 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                            Coverage Diff                             @@
##           cursor/semi-flat-wall-constructions-2cb3     #62     +/-   ##
==========================================================================
- Coverage                                      67.0%   66.8%   -0.3%     
==========================================================================
  Files                                            42      42             
  Lines                                          5518    5574     +56     
  Branches                                        512     514      +2     
==========================================================================
+ Hits                                           3701    3725     +24     
- Misses                                         1651    1680     +29     
- Partials                                        166     169      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants