Skip to content

perf(redis): speed up key browser scans#256

Merged
t8y2 merged 1 commit into
t8y2:mainfrom
yavon007:main
May 13, 2026
Merged

perf(redis): speed up key browser scans#256
t8y2 merged 1 commit into
t8y2:mainfrom
yavon007:main

Conversation

@yavon007
Copy link
Copy Markdown
Contributor

Summary

speed up key browser scans

Refs #255

Copy link
Copy Markdown
Owner

@t8y2 t8y2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Well Done

  • Pipeline batching — Replaces N sequential TYPE round-trips with a single redis::pipe(), which is the correct Redis optimization for bulk key metadata.
  • Deferred detail loading — Removing per-key TTL / size / preview fetches from the scan path is a meaningful latency reduction, especially for large keyspaces. The get_value path still provides full details on selection.
  • Clean removalfetch_key_preview was only called from scan_keys_page; deleting it entirely avoids dead code.
  • Frontend consistencyformatTtl and updated formatSize correctly render placeholder values as empty strings rather than misleading zeros.
  • Vec::with_capacity and early return on empty keys are nice touches.

Verdict

Clean performance optimization with no correctness or safety regressions. LGTM 👍

@t8y2 t8y2 merged commit eefa054 into t8y2:main May 13, 2026
2 checks passed
@t8y2
Copy link
Copy Markdown
Owner

t8y2 commented May 13, 2026

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants