@W-21748754: Add get-custom-view-data tool#308
Merged
mattcfilbert merged 6 commits intomainfrom Apr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for retrieving CSV data for Tableau Custom Views via a new MCP tool, and extends existing view tools to support optional viewFilters that are forwarded to the REST API as vf_* query parameters.
Changes:
- Introduces new
get-custom-view-datatool (tool registration, OAuth scopes, REST SDK methods, docs, and tests). - Adds optional
viewFilterssupport to view image/data flows (REST SDK + docs + tests). - Improves REST response logging by including query
paramsin interceptor config (used for URL construction in logs).
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/oauth/tableau-authz/tests/getCustomViewDatatest.ts | Adds OAuth authz test for get-custom-view-data tool |
| tests/e2e/views/getCustomViewData.test.ts | Adds E2E test validating custom view CSV output |
| src/tools/views/getViewImage.ts | Adds viewFilters param support and updates tool description |
| src/tools/views/getViewData.ts | Adds viewFilters param to schema (but currently not applied in callback) |
| src/tools/views/getViewData.test.ts | Updates tests and adds coverage for forwarding viewFilters |
| src/tools/views/getCustomViewData.ts | Implements new get-custom-view-data tool |
| src/tools/views/getCustomViewData.test.ts | Unit tests for new tool, including allowlist behavior and filter forwarding |
| src/tools/tools.ts | Registers new tool factory |
| src/tools/toolName.ts | Adds tool name and groups it under view |
| src/tools/resourceAccessChecker.ts | Adds isCustomViewAllowed and custom-view caching |
| src/tools/resourceAccessChecker.test.ts | Adds tests for isCustomViewAllowed behavior |
| src/server/oauth/scopes.ts | Adds OAuth scope mapping for new tool |
| src/sdks/tableau/methods/viewsMethods.ts | Adds REST methods for custom view + adds viewFilters support to view data/image methods |
| src/sdks/tableau/interceptors.ts | Extends response interceptor config to include params |
| src/sdks/tableau/apis/viewsApi.ts | Adds custom view endpoints and “dummy” query param for CSV endpoints |
| src/restApiInstance.ts | Uses response params when building logged response URLs |
| src/logging/secretMask.test.ts | Updates tests for new params field in response masking |
| docs/docs/tools/views/get-view-image.md | Documents viewFilters for get-view-image |
| docs/docs/tools/views/get-view-data.md | Documents viewFilters for get-view-data |
| docs/docs/tools/views/get-custom-view-data.md | Adds docs page for new tool |
| docs/docs/intro.md | Adds new tool to the overall tool list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anyoung-tableau
commented
Apr 15, 2026
anyoung-tableau
commented
Apr 15, 2026
anyoung-tableau
commented
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: