fix(SelectRange): Fix frozen column width calculation#4802
Open
xxxace wants to merge 3 commits into
Open
Conversation
xxxace
commented
Sep 10, 2025
xxxace
commented
- Adjust z-index of range selection element for proper display
- Fix calculation to consider all occupied frozen columns
- Adjust z-index of range selection element for proper display - Fix calculation to consider all occupied frozen columns
Author
azmy60
requested changes
Apr 1, 2026
| this.rangeManager.overlay.style.zIndex = 10; | ||
| } else { | ||
| // - z-index 11: Selection occupies at least one frozen column (ensures visibility above other elements) | ||
| this.rangeManager.overlay.style.zIndex = 11; |
Collaborator
There was a problem hiding this comment.
Could we remove this, please? Increasing the z-index from css should be enough. No need to conditionally assign a style here.
azmy60
added
the
PR Needs Work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.