Skip to content

Print calculation#2

Open
mzinger wants to merge 2 commits intotagel:masterfrom
mzinger:patch-2
Open

Print calculation#2
mzinger wants to merge 2 commits intotagel:masterfrom
mzinger:patch-2

Conversation

@mzinger
Copy link
Copy Markdown

@mzinger mzinger commented Jul 27, 2019

Review and print!


This change is Reviewable

Review and print!
@tagel tagel self-requested a review July 27, 2019 04:12
Copy link
Copy Markdown
Owner

@tagel tagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @mzinger and @tagel)


Math, line 1 at r1 (raw file):

import math

FYI: mm


Math, line 2 at r1 (raw file):

import math
math.calc()

minor: ff


Math, line 4 at r1 (raw file):

reviewable
``

Missing capital letter Reviewable()


Math, line 6 at r1 (raw file):

math.reviewable()

print "calced!"

don't forget to remove this before commiting

Copy link
Copy Markdown
Author

@mzinger mzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @tagel)


Math, line 2 at r1 (raw file):

Previously, tagel wrote…

minor: ff

OK, thanks for the heads up


Math, line 4 at r1 (raw file):

Previously, tagel wrote…
reviewable
``

Missing capital letter Reviewable()

Done.


Math, line 6 at r1 (raw file):

Previously, tagel wrote…

don't forget to remove this before commiting

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants