Open
Conversation
Review and print!
tagel
requested changes
Jul 27, 2019
Owner
tagel
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @mzinger and @tagel)
Math, line 1 at r1 (raw file):
import math
FYI: mm
Math, line 2 at r1 (raw file):
import math math.calc()
minor: ff
Math, line 4 at r1 (raw file):
reviewable ``
Missing capital letter Reviewable()
Math, line 6 at r1 (raw file):
math.reviewable() print "calced!"
don't forget to remove this before commiting
mzinger
commented
Jul 27, 2019
Author
mzinger
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @tagel)
Math, line 2 at r1 (raw file):
Previously, tagel wrote…
minor: ff
OK, thanks for the heads up
Math, line 4 at r1 (raw file):
Previously, tagel wrote…
reviewable ``Missing capital letter Reviewable()
Done.
Math, line 6 at r1 (raw file):
Previously, tagel wrote…
don't forget to remove this before commiting
Done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review and print!
This change is