feat(input): auto-wrap drag-and-dropped file paths with @[] syntax#2808
Merged
tusharmath merged 15 commits intotailcallhq:mainfrom Apr 12, 2026
Merged
Conversation
|
|
github-actions
bot
added
the
type: feature
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
When a user drags and drops a file onto the terminal, the terminal pastes the raw file path as text. Forge requires @[path] syntax to recognise file references, so dropped files were silently ignored. This commit detects bare file paths and wraps them at paste time so the @[...] reference appears immediately in the input buffer: - Reedline editor (editor.rs): a custom ForgeEditMode wraps the default Emacs mode and intercepts crossterm Paste events. The pasted text is transformed before it reaches the reedline buffer, giving the user instant visual feedback. - Zsh shell plugin (bindings.zsh): the forge-bracketed-paste widget intercepts pasted text and wraps it when it points to an existing file. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
strip_surrounding_quotes would panic on a single quote character because slicing s[1..0] is an invalid range. Add an early return for strings shorter than 2 characters. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
- Remove fast path in wrap_pasted_text that discarded surrounding whitespace from the original paste content. - Add double-quote stripping in the zsh bracketed-paste widget to match the Rust implementation which already handled both quote styles. Co-Authored-By: ForgeCode <noreply@forgecode.dev>
tapizquent-gail
force-pushed
the
feat/auto-wrap-dropped-file-paths
branch
from
9715d7f to
3f4b3e8
Compare
Contributor
Author
|
This also pretty much addresses #2811 , as you can copy an image anywhere and just paste it with the proper syntax now |
Collaborator
|
@tapizquent-gail Does this work with zsh plugin as well? |
Contributor
Author
Yes. Screen.Recording.2026-04-02.at.21.42.40.mov |
tusharmath
reviewed
Apr 3, 2026
- Fix Rust wrap_pasted_text to try entire paste as a single path before token splitting, handling bare paths with spaces - Add backslash-escape awareness: strip '\ ' to ' ' before is_file() checks so terminal drag-and-drop (Ghostty, iTerm2) works correctly - Update tokenizer to treat backslash-space as non-boundary so escaped paths stay as a single token - Fix zsh forge-bracketed-paste to handle backslash-escaped and quoted paths with spaces - Add forge-accept-line fallback (_forge_wrap_file_paths) for terminals that don't emit bracketed-paste on drag-and-drop (e.g. JetBrains) - Only trigger @[] wrapping when zsh buffer starts with ':' (sentinel) - Add zsh test script (scripts/test-zsh-utils.sh) with 21 correctness and performance tests Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Move all file path detection and @[...] wrapping logic from the zsh plugin into Rust, exposed as a new `forge zsh format --buffer <text>` CLI subcommand. This addresses the PR review comment requesting a single well-tested implementation. Changes: - Add ZshCommandGroup::Format variant with --buffer arg to CLI - Make wrap_pasted_text() public so it can be called from the dispatch - Simplify forge-bracketed-paste widget to delegate to forge zsh format - Simplify forge-accept-line dispatcher to delegate to forge zsh format - Remove _forge_wrap_file_paths and _forge_unescape_backslashes from zsh helpers (139 lines of zsh replaced by a one-line CLI call) - Update test script to exercise forge zsh format end-to-end - Add CLI parsing test for the new subcommand Net: -156 lines (79 added, 235 removed) Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Contributor
Author
|
Improved, now works with paths or files containing spaces and uses rust syntax for |
Collaborator
|
@tapizquent-gail I think we need a better way to make it work with RustRover and VSCode. We need to insert in the terminal with proper syntax highlighting to suggest that that a file has been attached. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user drags and drops a file onto the terminal, the terminal pastes the raw file path as text. Forge requires @[path] syntax to recognise file references, so dropped files were silently ignored.
This commit detects bare file paths and wraps them at paste time so the @[...] reference appears immediately in the input buffer:
Screen.Recording.2026-04-02.at.17.47.39.mov