fix(auth): preserve Codex id_token during OAuth exchange#2946
Open
Edition-X wants to merge 4 commits intotailcallhq:mainfrom
Open
fix(auth): preserve Codex id_token during OAuth exchange#2946Edition-X wants to merge 4 commits intotailcallhq:mainfrom
Edition-X wants to merge 4 commits intotailcallhq:mainfrom
Conversation
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
|
|
github-actions
bot
added
the
type: fix
| .set_auth_uri(AuthUrl::new(config.auth_url.to_string())?) | ||
| .set_token_uri(TokenUrl::new(config.token_url.to_string())?); | ||
| let http_client = self.build_http_client(config)?; | ||
| let mut params = vec
There was a problem hiding this comment.
make a concreate rust type
Co-Authored-By: ForgeCode <noreply@forgecode.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2947
Summary
id_tokenWhy
Codex credential enrichment prefers
id_tokenclaims to derivechatgpt_account_id, but the previous code droppedid_tokenduring token exchange. That made login behavior depend on whether the access token happened to contain the same claim.Verification