add config option for control URL#42
Merged
Merged
Conversation
willnorris
force-pushed
the
will/controlurl
branch
3 times, most recently
from
May 8, 2024 19:42
53295fe to
6052e1e
Compare
Contributor
|
Ohhh that's nice that it works with Headscale |
willnorris
force-pushed
the
will/controlurl
branch
3 times, most recently
from
May 8, 2024 20:33
9fa40cb to
04c5a82
Compare
irbekrm
approved these changes
May 9, 2024
irbekrm
left a comment
irbekrm
left a comment
Contributor
There was a problem hiding this comment.
Thanks, tried to deploy with the default https://controlplane.tailscale.com URL specified for this option and all worked as expected 👍🏼
Suggestion: document this option in Readme and/or add it with the default value to the top level Caddyfile?
also return any replacer errors, and remove app nil check since we always check prior to calling these config funcs. Closes #22 Co-authored-by: ChibangLW <ich@leonlenzen.de> Signed-off-by: Will Norris <will@tailscale.com>
willnorris
force-pushed
the
will/controlurl
branch
from
May 9, 2024 14:38
04c5a82 to
a92d1bc
Compare
Member
Author
|
So, it's kinda funny.... I have a separate branch I started last week where I'm doing a pretty heavy pass over all of the documentation. A lot of these changes actually came out of that, realizing that it's somewhat confusing to explain the old way of doing things. So a full doc update is definitely coming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
I successfully tested this with headscale, which was pretty neat :)