Open
Conversation
Signed-off-by: Twentybit <60849886+twentybit@users.noreply.github.com>
Signed-off-by: Twentybit <60849886+twentybit@users.noreply.github.com>
|
Awesome to see an helm chart get added to this. I've made a helm chart for golink, and I've found the following things useful, maybe these things can be added to this chart as well:
I can help adopting that, if we want this, or make a follow-up PR, as an alternative. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a working copy of a helm chart used to deploy tsidp on kubernetes. I raised #94 for this request.
I've included
fsGroupandrunAsUserdefaults in the values.yaml to fix PVC storage caused by #113I've not included a GitHub workflow as I'm not sure how you'd want to lint/test/release this (if this is accepted!). Happy collaborating on that part if this looks like a good base?
Here's a copy of the k8s manifests generated using the default values:
$ helm template --dry-run chart