You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix data race and use-after-free in napi_threadsafe_function by @toyobayashi in #199
fix tsfn not work in JS based async_work workers
fix pthread_create not work in JS based async_work workers
emnapi_basic[-mt].a includes libuv symbols now
refactor: dispatch async work queue in shared memory by @toyobayashi in #200
Avoids deadlock when main thread block on waiting queued async work starting. Completed work can not be dispatched to main thread that cause no new worker available, then queued work never start.
wasm32-wasip1-threads target spawn async worker in JS will use pthread_create, no longer maintain a separate worker pool.
rename node_api_create_object_with_properties by @toyobayashi in #193
fix: execute tsfn finalizer after queue drains when aborted
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.
All Depfu comment commands
@depfu rebase
Rebases against your default branch and redoes this update
@depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@depfu cancel merge
Cancels automatic merging of this PR
@depfu close
Closes this PR and deletes the branch
@depfu reopen
Restores the branch and reopens this PR (if it's closed)
@depfu pause
Ignores all future updates for this dependency and closes this PR
@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 6ae96c47-4c56-478c-8612-deeb0932ede7
📥 Commits
Reviewing files that changed from the base of the PR and between 3a890c3 and 1e050d9.
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
crates/node/npm/wasm32-wasi/package.json
Walkthrough
This change updates the @emnapi/core npm package dependency in the wasm32-wasi package configuration. The version constraint is upgraded from ^1.8.1 to ^1.9.2 within the dependencies section. No other dependencies or package metadata fields are modified. The change consists of a single line modification with no impact on exported or public entity declarations.
The title accurately describes the main change: updating @emnapi/core from 1.8.1 to 1.9.2, which matches the raw_summary and is concise and clear.
Description check
✅ Passed
The description is directly related to the changeset, providing comprehensive release notes and commit details for the @emnapi/core dependency update from 1.8.1 through 1.10.0.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
At least 1 approving review is required by reviewers with write access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ @emnapi/core (1.8.1 → 1.10.0) · Repo
Release Notes
1.10.0
1.9.2
1.9.1
1.9.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 22 commits:
1.10.0fix: free queue node and set async_pending flag before finalizefix: tsfn use after freeci: llvm 22fix: coalesce tsfn send message (#210)test: fix async_progress_worker test (#209)ci: restructure CI workflows (#208)fix: add missing `from64` wrapfix!: `napi_adjust_external_memory` no longer grow wasm memory (#207)fix: early update wasm memory for views (#206)ci: manual release1.9.2[Backport] fix: allow maximum memory 4GB (#205)1.9.1fix for emscripten 5.0.31.9.0feat: add required config hint in package entryfix: execute tsfn finalizer after queue drains when aborted (nodejs/node#61956)refactor: dispatch async work queue in shared memory (#200)[Backport] fix data race and use-after-free in napi_threadsafe_function (#199)feat!: fix `node_api_create_object_with_properties` name (#193)refactor: use Node-API in comments (#194)Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands