chore: add changeset for #626 (dialog component types)#634
Open
deepjoy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing changeset for #626 ("fix: add proper types for dialog components", merged 2025-12-20 as commit 8cf3226), so the patch can ship in the next release.
The fix is on
mainbut isn't in any published version (5.1.1and the latestnextbuild both predate it), which means downstream consumers still hit the underlying type error intypings-for-build/app/src/ui.tsx. In particular,@typescript/native-preview(tsgo) reports it fromnode_moduleseven withskipLibCheck: true— the@ts-ignoredirectives that #626 removed weren't enough on the new compiler.No code changes — just the missing
.changeset/*.mdfile that #626 forgot to include, so the next Version Packages run picks it up.