fix: alias values were not being set properly#53
Open
FerroEduardo wants to merge 2 commits intotakenet:mainfrom
Open
fix: alias values were not being set properly#53FerroEduardo wants to merge 2 commits intotakenet:mainfrom
FerroEduardo wants to merge 2 commits intotakenet:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
===========================================
- Coverage 82.11% 68.19% -13.93%
===========================================
Files 26 30 +4
Lines 3696 4823 +1127
===========================================
+ Hits 3035 3289 +254
- Misses 519 1384 +865
- Partials 142 150 +8
|
juniorrhis1
approved these changes
Oct 25, 2024
abbe266 to
53d397c
Compare
53d397c to
26a946f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As values are read using
internal/config/viper_config.go, it is unnecessary to useviper.SetDefault(), as the default value fromViperConfigKeyis used if the variable is not set.deckard/internal/config/viper_config.go
Lines 36 to 52 in 6083960
Fixes #51