Skip to content

Conversation

@kronenpj
Copy link

This is a set of minor changes that address the API incompatibility introduced in headscale change #2993

I may have done this wrong - I don't do much Typescript coding. However, the changes work for me.
Verified changing tags as well as general machine list operation. I did not check to see whether the tags made it into headscale.

Feel free to use or reject this change. I hope it saves you some time.

@kronenpj kronenpj requested a review from tale as a code owner January 22, 2026 19:09
@kronenpj
Copy link
Author

May fix #432

@tale
Copy link
Owner

tale commented Jan 24, 2026

It needs to be backwards compatible with atleast 0.26. I'm thinking we coalesce these tags in with the API fetcher internally so that its exposed as tags for both versions before and after 0.28.0. In the API fetcher it's possible to check versions, it should've been exposed from the start.

@kronenpj
Copy link
Author

My apologies, I should have thought of that. I've tried to make adjustments so that the UI works with beta 2 as well as prior versions, but haven't been successful. I'm stuck on the machine-row population routine throwing node.tags is not iterable on prior API versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants