Add code-review-cordova agent skill#69
Merged
Merged
Conversation
Adds a strict code review skill covering TypeScript, Kotlin, and Swift bridge layers, plugin.xml action string alignment, persistent callbackId rules, platform-asymmetric getThreatChannelData, and www/dist/ handling. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agents/skills/code-review-cordova/SKILL.md— a strict code review skill for this Cordova pluginwww/src/), Kotlin + Swift native bridges,plugin.xml, andwww/dist/build outputplugin.xml/ action string alignment across four layers (TS, Kotlin, Swift, XML), persistentcallbackId/keepCallback = truerules, platform-asymmetricgetThreatChannelDatashape (2 strings Android / 1 string iOS),EventIdentifiersobfuscation rules, and'started'wire-format constantcode-review-flutterskill pattern, adjusted for Cordova bridge mechanics (no event emitter — persistent callbackId) and npm as the package managerTest plan
npm, notyarndataLengthasymmetry note surfaces correctly when reviewing changes to channel filesMade with Cursor