fix: serve Ctrl-C stop#38
Open
zkd-11 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes shutdown handling for the
kage servecommand:SIGINTandSIGTERMso the running server can be stopped cleanly.Details
Previously,
kage servecould printpress Ctrl-C to stop, but pressingCtrl+Cdid not reliably terminate the process in some terminal environments. The process could keep running and continue holding port8800.This change updates the CLI entrypoint to listen for both
os.Interruptandsyscall.SIGTERM. Once the first signal is received, it restores the default signal behavior so a secondCtrl+Ccan force termination.The
servecommand now shuts down its HTTP server throughhttp.Server.Shutdownwith a short timeout, falling back toCloseif graceful shutdown fails. This releases the listening port after cancellation.Testing
Manual checks:
Ctrl+Cstopskage serve.8800is released after shutdown.SIGTERMalso stops the server cleanly.