Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
swift build --show-bin-pathinstead of hardcoded paths.Description
.github/workflows/ci.ymlthat runs on macOS and executesswift testand./build-app.sh debugfor push and pull_request events.build-app.shthat supportsdebug|release, checks macOS runtime, uses--show-bin-path, creates properContents/layout, copies executable, and generates an.icnsfrom the XcodeAppIcon.appiconsetwheniconutilis available;create-app-bundle.shandrun-lucid.shnow delegate tobuild-app.sh.Makefileto addCONFIGvariable, new targets (test,install), useswift build --configuration $(CONFIG), and open/install the built.appusing the--show-bin-pathbin path.Package.swiftto excludeInfo.plistandLucid.entitlementsfrom the executable target resources.ProcessMonitorpolling interval from 3.0s to 2.0s and make therefresh()function setisRefreshing = falseviadeferto ensure the guard is released even on early returns; remove redundantisRefreshingreset inside theMainActorblock.README.mdwith project status, CI details, updated build/run instructions, and documentation reflecting the 2s poll interval and updated tooling.Testing
swift testand./build-app.sh debugon macOS via.github/workflows/ci.yml, but no CI run results are included in this PR.swift testormake test, and app bundle verification can be run with./build-app.sh debugas configured in the workflow.